[FIXED] Discard Policy was incorrectly displayed. #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, a discard "new" policy was displayed as: ``` Discard Policy: NewNew ``` Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@ripienaar Not sure if there are tests for the UI, if there are, please point them to me and I can try to add a test for that. |
|
There are tests but more testing the side effect based stuff. Say you create a stream with a option I then check tbe option is in effect. For the pure display stuff no tests see cli package there is a test there but I think fine to skip here |
|
Yes, I saw that test, but indeed more testing that the resulting state is matching the params, etc.., but not UI per-se. Do you merge or am I supposed to? |
|
You can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, a discard "new" policy was displayed as:
Signed-off-by: Ivan Kozlovic ivan@synadia.com